Differential D14086

[effects/slidingpopups] Use range-based for loops
ClosedPublic
Actions

Authored by zzag on Jul 13 2018, 7:01 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:049c6e0966ce: [effects/slidingpopups] Use range-based for loops

Diff Detail

Repository
R108 KWin
Branch
effects-slidingpopups-overhaul
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 802
Build 815: arc lint + arc unit
zzag created this revision.Jul 13 2018, 7:01 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 13 2018, 7:01 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 13 2018, 7:01 AM
davidedmundson accepted this revision.Jul 13 2018, 10:47 AM
davidedmundson added a subscriber: davidedmundson.

Would have expected some fancy std::remove_if from you

This revision is now accepted and ready to land.Jul 13 2018, 10:47 AM
zzag added a comment.Jul 13 2018, 11:01 AM
In D14086#291473, @davidedmundson wrote:

Would have expected some fancy std::remove_if from you

Well, yeah, I could use std::copy_if. But I think that's fine to use loops here.

Closed by commit R108:049c6e0966ce: [effects/slidingpopups] Use range-based for loops (authored by zzag). · Explain WhyJul 14 2018, 7:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37681

View Options

effects/slidingpopups/slidingpopups.cpp

Loading...