diff --git a/backends/xcbeventlistener.h b/backends/xcbeventlistener.h --- a/backends/xcbeventlistener.h +++ b/backends/xcbeventlistener.h @@ -64,12 +64,11 @@ protected: bool m_isRandrPresent; bool m_event11; - int m_randrBase; - int m_randrErrorBase; - int m_majorOpcode; - int m_eventType; - int m_versionMajor; - int m_versionMinor; + uint8_t m_randrBase; + uint8_t m_randrErrorBase; + uint8_t m_majorOpcode; + uint32_t m_versionMajor; + uint32_t m_versionMinor; uint32_t m_window; }; diff --git a/backends/xcbeventlistener.cpp b/backends/xcbeventlistener.cpp --- a/backends/xcbeventlistener.cpp +++ b/backends/xcbeventlistener.cpp @@ -26,17 +26,15 @@ Q_LOGGING_CATEGORY(KSCREEN_XCB_HELPER, "kscreen.xcb.helper") XCBEventListener::XCBEventListener(): - QObject(), m_isRandrPresent(false), m_randrBase(0), m_randrErrorBase(0), m_majorOpcode(0), - m_eventType(0), m_versionMajor(0), m_versionMinor(0), m_window(0) { - xcb_connection_t* c = QX11Info::connection(); + xcb_connection_t *c = QX11Info::connection(); xcb_prefetch_extension_data(c, &xcb_randr_id); auto cookie = xcb_randr_query_version(c, XCB_RANDR_MAJOR_VERSION, XCB_RANDR_MINOR_VERSION); const auto *queryExtension = xcb_get_extension_data(c, &xcb_randr_id); @@ -55,7 +53,7 @@ m_majorOpcode = queryExtension->major_opcode; xcb_generic_error_t *error = nullptr; - auto* versionReply = xcb_randr_query_version_reply(c, cookie, &error); + auto *versionReply = xcb_randr_query_version_reply(c, cookie, &error); Q_ASSERT_X(versionReply, "xrandrxcbhelper", "Query to fetch xrandr version failed"); if (error) { qFatal("Error while querying for xrandr version: %d", error->error_code); @@ -134,7 +132,7 @@ return false; } - xcb_generic_event_t* e = static_cast(message); + auto *e = static_cast(message); const uint8_t xEventType = e->response_type & ~0x80; //If this event is not xcb_randr_notify, we don't want it @@ -150,8 +148,7 @@ void XCBEventListener::handleScreenChange(xcb_generic_event_t* e) { - xcb_randr_screen_change_notify_event_t *e2 = - (xcb_randr_screen_change_notify_event_t *) e; + auto *e2 = reinterpret_cast(e); // Only accept notifications for our window if (e2->request_window != m_window) { @@ -172,8 +169,7 @@ void XCBEventListener::handleXRandRNotify(xcb_generic_event_t* e) { - xcb_randr_notify_event_t* - randrEvent = reinterpret_cast(e); + auto *randrEvent = reinterpret_cast(e); if (randrEvent->subCode == XCB_RANDR_NOTIFY_CRTC_CHANGE) { xcb_randr_crtc_change_t crtc = randrEvent->u.cc;