[Folder View] Create rename editor on demand
ClosedPublic

Authored by broulik on Jul 12 2018, 12:34 PM.

Details

Summary

Creating a TextArea is surprisingly costly.

Test Plan
  • Renaming files via context menu and F2 still works
  • Text field is properly placed
  • Hitting escape cancels rename as before
  • Hitting return or clicking outside commits rename like before
  • Keyboard navigation within the text field (Home, End, Shift select etc) works fine
  • Delegate label still hides properly while renaming

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 12 2018, 12:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 12 2018, 12:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 12 2018, 12:34 PM
hein accepted this revision.Jul 12 2018, 12:47 PM
This revision is now accepted and ready to land.Jul 12 2018, 12:47 PM
This revision was automatically updated to reflect the committed changes.