This trivial patch adds the missing parameter to get the familiar behaviour working for redshift versions since 1.12.
BUG: 395641
Details
Details
Diff Detail
Diff Detail
- Repository
- R885 Redshift Control for Plasma
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I was hoping the bug would get linked in automatically... anyways, here it is, with additional information: https://bugs.kde.org/show_bug.cgi?id=395641
Comment Actions
It breaks, as redshift <1.12 will exit with "invalid option -- 'P'".
I initially just thought of this as packaging responsibility, however, users might install those applets independently from distribution's packages.
It would be possible to make a runtime check, look for the version no. with redshift -V and add the -P switch dynamically. However, I'm not familiar with QML or where this call would be added. I thought of something like
...
property string redshiftCompat: getInstalledRedshiftVersion().split(' ')[1] < '1.12' ? '' : '-P'
property string redshiftOneTimeCommand: 'redshift -O ' + redshiftCompat + ...