Differential D14065

Be strict about implicit string casts
ClosedPublic
Actions

Authored by gladhorn on Jul 12 2018, 8:07 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R104:e9cca953e8bc: Be strict about implicit string casts
Summary

Use QT_NO_CAST_FROM_ASCII and friends. There are a bunch of places where
QString should really be QByteArray, but that's for the future.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Jul 12 2018, 8:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 12 2018, 8:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 12 2018, 8:07 AM
zzag added a subscriber: zzag.Jul 12 2018, 8:16 AM
zzag added inline comments.
CMakeLists.txt
11–16

Use 4 spaces to indent.

apol accepted this revision.Jul 12 2018, 9:24 AM
This revision is now accepted and ready to land.Jul 12 2018, 9:24 AM
Closed by commit R104:e9cca953e8bc: Be strict about implicit string casts (authored by gladhorn). · Explain WhyJul 12 2018, 9:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (9 lines)
Mconsole/console.cpp (4 lines)
Mkcm/src/utils.cpp (2 lines)
Mkded/daemon.cpp (8 lines)
Mkded/osdmanager.cpp (2 lines)
Mkded/serializer.cpp (2 lines)
Mtests/kded/serializertest.cpp (28 lines)
Mtests/osd/main.cpp (8 lines)

Diff 37630

View Options

CMakeLists.txt

Loading...
View Options

console/console.cpp

Loading...
View Options

kcm/src/utils.cpp

Loading...
View Options

kded/daemon.cpp

Loading...
View Options

kded/osdmanager.cpp

Loading...
View Options

kded/serializer.cpp

Loading...
View Options

tests/kded/serializertest.cpp

Loading...
View Options

tests/osd/main.cpp

Loading...