Differential D14046

[effects/desktopgrid] Don't change activities
ClosedPublic
Actions

Authored by zzag on Jul 11 2018, 1:23 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:0c3047a8f1d4: [effects/desktopgrid] Don't change activities
R108:e918cb5d2d3d: [effects/desktopgrid] Don't change activities
Summary

If the Desktop Grid effect doesn't use the Present Windows effect to
layout windows, windowAt helper can return a window that doesn't belong
to current activity because it doesn't check whether that window belongs
to current activity.

This change addresses that problem by adding corresponding check.

BUG: 301447
FIXED-IN: 5.13.4

Test Plan

Unchecked "Use Present Windows effect to layout the windows".

  • Switched to activity #1
  • Switched to virtual desktop #1
  • Launched Konsole and maximized it(to increate hit area)
  • Switched to activity #2
  • Switched to virtual desktop #2
  • Launched Dolphin and maximized it
  • Activated the Desktop Grid effect, clicked on virtual desktop #1 (activity #2 is still active)
  • Switched to activity #1
  • Activated the Desktop Grid effect, clicked on virtual desktop #2 (activity #1 is still active)

Diff Detail

Repository
R108 KWin
Branch
effects-desktop-grid-windowat-activity
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 748
Build 760: arc lint + arc unit
zzag created this revision.Jul 11 2018, 1:23 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 11 2018, 1:23 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 11 2018, 1:23 PM
davidedmundson accepted this revision.Jul 11 2018, 1:24 PM
This revision is now accepted and ready to land.Jul 11 2018, 1:24 PM
Closed by commit R108:0c3047a8f1d4: [effects/desktopgrid] Don't change activities (authored by zzag). · Explain WhyJul 11 2018, 2:06 PM
This revision was automatically updated to reflect the committed changes.
januz awarded a token.Jul 11 2018, 2:30 PM

Revision Contents
Changeset List

Diff 37560

View Options

effects/desktopgrid/desktopgrid.cpp

Loading...