Differential D14044

Simplify getting edid in xrandr backend
ClosedPublic
Actions

Authored by gladhorn on Jul 11 2018, 9:19 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R110:e4236e02b814: Simplify getting edid in xrandr backend
Summary

XRandR::outputEdid is used in only one place, let it return a byte array directly.

Diff Detail

Repository
R110 KScreen Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Jul 11 2018, 9:19 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 11 2018, 9:19 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 11 2018, 9:19 AM
davidedmundson accepted this revision.Jul 11 2018, 10:25 AM
This revision is now accepted and ready to land.Jul 11 2018, 10:25 AM
zzag added a subscriber: zzag.Jul 11 2018, 10:49 AM
zzag added inline comments.
backends/xrandr/xrandr.cpp
273

reinterpret_cast<char*>(result)

275

It would be great to use QScopedPointer, but that would be unrelated change, I guess.

gladhorn added inline comments.Jul 11 2018, 11:38 AM
backends/xrandr/xrandr.cpp
273

I agree, but there are more places with c-style casts, let's clean them all up in one go. This is just moving things.

Closed by commit R110:e4236e02b814: Simplify getting edid in xrandr backend (authored by gladhorn). · Explain WhyJul 11 2018, 11:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37557

View Options

backends/xrandr/xrandr.h

Loading...
View Options

backends/xrandr/xrandr.cpp

Loading...
View Options

backends/xrandr/xrandroutput.cpp

Loading...