Differential D14038

IncrementalSearchBox: fix rendering during terminal scroll
ClosedPublic
Actions

Authored by mglb on Jul 11 2018, 2:10 AM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:e176667d6809: IncrementalSearchBox: fix rendering during terminal scroll
Summary

Prevent search widget from moving when scrolling session.

BUG: 396119

Test Plan
  • Run seq 1000
  • Turn on search
  • Hold Shift+Up, Shift+Down

Actual result: the search box scrolls with terminal contents
Expected result: only terminal should scroll, the box should remain
unchanged

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb created this revision.Jul 11 2018, 2:10 AM
Restricted Application added a project: Konsole. · View Herald TranscriptJul 11 2018, 2:10 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
mglb requested review of this revision.Jul 11 2018, 2:10 AM
mglb edited the test plan for this revision. (Show Details)Jul 11 2018, 2:15 AM
mglb added a reviewer: Konsole.
ngraham added a subscriber: ngraham.Jul 11 2018, 3:23 AM

Please add BUG: 396119 since this fixes that bug.

mglb edited the summary of this revision. (Show Details)Jul 11 2018, 3:34 AM
hindenburg accepted this revision.Jul 11 2018, 11:24 AM
hindenburg added a subscriber: hindenburg.

very nice - glad this was a simple fix

This revision is now accepted and ready to land.Jul 11 2018, 11:24 AM
ngraham added a comment.Jul 11 2018, 11:38 AM

Awesome, now don't forget to run arc amend on your local checkout before landing. :)

hindenburg edited the summary of this revision. (Show Details)Jul 12 2018, 12:43 AM

I had to add more info in the summary area to get the BUG: to be on a new line instead of summary line.

Closed by commit R319:e176667d6809: IncrementalSearchBox: fix rendering during terminal scroll (authored by mglb, committed by hindenburg). · Explain WhyJul 12 2018, 12:49 AM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Jul 12 2018, 1:02 PM
In D14038#290801, @hindenburg wrote:

I had to add more info in the summary area to get the BUG: to be on a new line instead of summary line.

That bug in the parser that imposed this restriction has since been fixed, BTW. the BUG: keyword can now be on the first line here in Phabricator.

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.cpp (2 lines)

Diff 37603

View Options

src/TerminalDisplay.cpp

Loading...