Differential D14029

[Kicker] Use KFilePlaces::convertedUrl for ComputerModel
ClosedPublic
Actions

Authored by broulik on Jul 10 2018, 1:46 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R120:659449387eae: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel
R119:3fe808ef8e97: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel
Summary

Fixes timeline and search URLs in "Computer" tab

BUG: 363337
FIXED-IN: 5.12.7

Test Plan

It causes it to show technical baloosearch:?json=blabla URLs as subtext but it's better than not working at all

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 10 2018, 1:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 10 2018, 1:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 10 2018, 1:46 PM
ngraham added a subscriber: ngraham.Jul 10 2018, 8:36 PM

Verified that this fixes the bug. Sadly this does make the subtitle somewhat ugly for the Search For entries in particular:

Is there nothing we can do about that?

hein added a comment.Jul 10 2018, 8:40 PM

Yeah, I think this isn't very pretty unfortunately. Does KIO have a way to give a human-readable description of an URL or something?

hein accepted this revision.Jul 10 2018, 8:42 PM

In the meantime this is a necessary bugfix though.

This revision is now accepted and ready to land.Jul 10 2018, 8:42 PM
Closed by commit R119:3fe808ef8e97: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel (authored by broulik). · Explain WhyJul 11 2018, 8:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37551

View Options

applets/kicker/plugin/computermodel.cpp

Loading...