[Kicker] Use KFilePlaces::convertedUrl for ComputerModel
ClosedPublic
Actions

Authored by broulik on Jul 10 2018, 1:46 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Fixes timeline and search URLs in "Computer" tab

BUG: 363337
FIXED-IN: 5.12.7

Test Plan

It causes it to show technical baloosearch:?json=blabla URLs as subtext but it's better than not working at all

Repository

R119 Plasma Desktop

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Jul 10 2018, 1:46 PM

Verified that this fixes the bug. Sadly this does make the subtitle somewhat ugly for the Search For entries in particular:

Is there nothing we can do about that?

Yeah, I think this isn't very pretty unfortunately. Does KIO have a way to give a human-readable description of an URL or something?

In the meantime this is a necessary bugfix though.

This revision is now accepted and ready to land.Jul 10 2018, 8:42 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applets/kicker/plugin/computermodel.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	37508			Jul 10 2018, 1:44 PM	★	★
Diff 2	37551	a6d4cab	R119:3fe808ef8e9763edd5c349f8556b7ee2c0645702	Jul 11 2018, 8:47 AM	★	★