Move KCM to UI file
ClosedPublic
Actions

Authored by gladhorn on Jul 10 2018, 8:55 AM.

Details

Reviewers

sebas
davidedmundson

Group Reviewers

Plasma

Commits

R104:ce68ee44e099: Move KCM to UI file

Summary

This fixes the size policy, the only element we want expanding is the
preview area on top, everything else should be layouted with preferred
size.

Repository

R104 KScreen

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

gladhorn requested review of this revision.Jul 10 2018, 8:55 AM

gladhorn added a reviewer: sebas.

Fixed stretch for unified outputs

If we're going to do any UI porting, how about to QML instead? That's the future.

Sure, but let's get there step by step. In general this needs some un-tangling of functionality and UI first.

OK, no problem. :)

This revision is now accepted and ready to land.Jul 11 2018, 1:09 PM

zzag added inline comments.

kcm/src/widget.h
46–48	Coding style nitpick: namespace Ui { class KScreenWidget; }
97	Naming nitpick: mUi

This revision was automatically updated to reflect the committed changes.

		Path
M		kcm/src/CMakeLists.txt (2 lines)
M		kcm/src/controlpanel.cpp (2 lines)
A	M	kcm/src/kscreen_widget.ui (101 lines)
M		kcm/src/outputconfig.cpp (4 lines)
M		kcm/src/widget.h (13 lines)
M		kcm/src/widget.cpp (112 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	37496	a9796bb		Jul 10 2018, 8:55 AM	★	★
Diff 2	37501	a9796bb	Fixed stretch for unified outputs	Jul 10 2018, 11:56 AM	★	★
Diff 3	37594	77ee982	R104:ce68ee44e0990370204e21cf501a05f25bb9410a	Jul 11 2018, 7:46 PM	★	★

Status	Author	Revision
Closed	gladhorn	D14025 Move scale and unify button to the top, next to primary combo
Closed	gladhorn	D14024 Move KCM to UI file
Closed	gladhorn	D14023 Make Primary Combo a regular QComboBox