Differential D14023

Make Primary Combo a regular QComboBox
ClosedPublic
Actions

Authored by gladhorn on Jul 10 2018, 8:54 AM.

Details

Reviewers

mart

Group Reviewers

Plasma

Commits

R104:77ee98211895: Make Primary Combo a regular QComboBox

Summary

This will make it easier to re-design the UI.
Also it centralizes all updates, before a bunch of connections for the
individual outputs were not made when a new output appeared.

Diff Detail

Repository

R104 KScreen

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

gladhorn created this revision.Jul 10 2018, 8:54 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJul 10 2018, 8:54 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

gladhorn requested review of this revision.Jul 10 2018, 8:54 AM

Harbormaster completed remote builds in B725: Diff 37495.Jul 10 2018, 8:54 AM

gladhorn added a reviewer: Plasma.Jul 10 2018, 9:11 AM

Need to remove debug statements.

kcm/src/widget.cpp
172	Left over debug statement. Remove.
503	remove
519	remove

Removed left over debug statements

Harbormaster completed remote builds in B729: Diff 37502.Jul 10 2018, 11:59 AM

gladhorn marked 3 inline comments as done.Jul 10 2018, 12:04 PM

gladhorn added a dependent revision: D14024: Move KCM to UI file.Jul 10 2018, 7:41 PM

Make diff slightly smaller (newlines) and remove a qDebug that was stil left over.

Harbormaster completed remote builds in B736: Diff 37530.Jul 10 2018, 8:00 PM

mart accepted this revision.Jul 11 2018, 8:51 AM

This revision is now accepted and ready to land.Jul 11 2018, 8:51 AM

Closed by commit R104:77ee98211895: Make Primary Combo a regular QComboBox (authored by gladhorn). · Explain WhyJul 11 2018, 9:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		kcm/src/CMakeLists.txt (1 line)
D	M	kcm/src/primaryoutputcombo.h (58 lines)
D	M	kcm/src/primaryoutputcombo.cpp (186 lines)
M		kcm/src/widget.h (11 lines)
M		kcm/src/widget.cpp (133 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	37495	c969d71		Jul 10 2018, 8:54 AM	★	★
Diff 2	37502	c969d71	Removed left over debug statements	Jul 10 2018, 11:59 AM	★	★
Diff 3	37530	c969d71	Make diff slightly smaller (newlines) and remove a qDebug that was stil left…	Jul 10 2018, 8:00 PM	★	★
Diff 4	37554	615b035	R104:77ee982118957f3dba33e2ed4d0fd42b6b90e396	Jul 11 2018, 9:15 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
17cc3ff0055b	40eb1987c748	c969d711afde	Frederik Gladhorn	Make Primary Combo a regular QComboBox (Show More…)	Jul 10 2018, 7:50 PM

Status	Author	Revision
Closed	gladhorn	D14025 Move scale and unify button to the top, next to primary combo
Closed	gladhorn	D14024 Move KCM to UI file
Closed	gladhorn	D14023 Make Primary Combo a regular QComboBox