This patch makes it possible to click on the song/album/artist name to enter the Now Playing/Album/Artist view in the corresponding album or artist.
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:43a459132783: [WIP] Make labels in header bar clickeable
R255:50f51b971edf: Make labels in header bar clickeable
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
This patch isn't finished yet. I've come across a problem with the album view: the openOneAlbum() function requires a databaseID to get the album data but I have no way of getting that in the header bar. I looked around the headerbarmanager code for a bit but I have no idea how we could fetch that. Everything else works.
I will take care of that hopefully before the end of the week. I have started working on it.
This is mostly done too but there's still one small bug: when I go to the now playing view and then click on the album name it doesn't open the album, but only switches to the album view.
Still trying to figure this out
@januz, @astippich does one of you want to finish this development ? That would be very nice to see it in the next version.
I'm currently quite busy with other things and would like to finish more of that before adding stuff to my todo list again...
I'll try to look into this again next weekend. I think Elisa was missing some way to go properly from Now Playing to a specific album view, so it went straight to all albums.
I tried to take another look at this, but after rebasing on master I started getting an error when building:
/home/januz/code/elisa/autotests/qabstractitemmodeltester.cpp:43:31: fatal error: private/qobject_p.h: No such file or directory compilation terminated. autotests/CMakeFiles/allalbumsmodeltest.dir/build.make:62: recipe for target 'autotests/CMakeFiles/allalbumsmodeltest.dir/qabstractitemmodeltester.cpp.o' failed
- do not expand labels in header bar but let them grow with the text
avoid having the MouseArea zone expand longer than the text
Thanks for your contribution. It is nice to have and made me fix quite some bugs in ViewManager class.