Require out-of-source build
ClosedPublic

Authored by ngraham on Jul 9 2018, 12:33 PM.

Details

Summary

KService doesn't build if you try to do an in-source build (fakeplugin.desktop gets renamed in the wrong place and CMake dies), so let's just require an out-of-source build, which people should be doing anyway.

Test Plan
  • Builds with an out-of-source build
  • Stops immediately if you try to do an in-source build

Diff Detail

Repository
R309 KService
Branch
require-in-source-build (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 700
Build 712: arc lint + arc unit
ngraham created this revision.Jul 9 2018, 12:33 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 9 2018, 12:33 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 9 2018, 12:33 PM
dfaure accepted this revision.Jul 9 2018, 12:43 PM
This revision is now accepted and ready to land.Jul 9 2018, 12:43 PM
This revision was automatically updated to reflect the committed changes.