Differential D14002

[libkwineffects] Use more std::transform in implementation part
ClosedPublic
Actions

Authored by zzag on Jul 9 2018, 12:07 PM.

Details

Reviewers
mart
Group Reviewers
KWin
Commits
R108:91e69e3fbd67: [libkwineffects] Use more std::transform in implementation part
Summary

These two should have been in D13821 but I missed them somehow.

Test Plan
  • Ran qdbus org.kde.KWin /Effects loadedEffects
  • Ran the following Python script
import dbus

bus = dbus.SessionBus()

effects_object = bus.get_object('org.kde.KWin', '/Effects')
effects_iface = dbus.Interface(
    effects_object,
    dbus_interface='org.kde.kwin.Effects'
)

names = (
    'slide',
    'pizza',
    'cube'
)

supported_statuses = effects_iface.areEffectsSupported(names)

for name, supported in zip(names, supported_statuses):
    print("%s: %s" % (name, supported))

Got the following output:

slide: 1
pizza: 0
cube: 1

Diff Detail

Repository
R108 KWin
Branch
libkwineffects-impl-more-std-transform
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 699
Build 711: arc lint + arc unit
zzag created this revision.Jul 9 2018, 12:07 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 9 2018, 12:07 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 9 2018, 12:07 PM
mart accepted this revision.Jul 10 2018, 4:30 PM
This revision is now accepted and ready to land.Jul 10 2018, 4:30 PM
Closed by commit R108:91e69e3fbd67: [libkwineffects] Use more std::transform in implementation part (authored by zzag). · Explain WhyJul 10 2018, 11:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects.cpp (20 lines)

Diff 37449

View Options

effects.cpp

Loading...