Differential D13998

[Logout Greeter] Remove KDM cruft
ClosedPublic
Actions

Authored by broulik on Jul 9 2018, 9:17 AM.

Details

Reviewers
davidedmundson
mart
Group Reviewers
Plasma
Commits
R120:485193ebcaf0: [Logout Greeter] Remove KDM cruft
Summary

KDisplayManager::bootOptions only worked with "NewKDM" but KDM is obsolete in Plasma 5. Creating an instance of KDisplayManager does DBus stuff to find out the DM being used.
Also, kdmrc is dead and this code always returned None anyway.

Test Plan

Saves almost 2ms greeter startup time for me
No QML undefined warnings and greeter still works fine

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 9 2018, 9:17 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 9 2018, 9:17 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 9 2018, 9:17 AM
mart accepted this revision.Jul 10 2018, 4:29 PM
This revision is now accepted and ready to land.Jul 10 2018, 4:29 PM
Closed by commit R120:485193ebcaf0: [Logout Greeter] Remove KDM cruft (authored by broulik). · Explain WhyJul 10 2018, 5:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37519

View Options

ksmserver/logout-greeter/shutdowndlg.cpp

Loading...