This patch removes all wayland related things in the Touchpad KCM.
For more details, see T9177
No Linters Available |
No Unit Test Coverage |
Buildable 696 | |
Build 708: arc lint + arc unit |
Since you can review the old diff, I'm moving to stage 2. If you have problem with the Stage 1's diff, please tell me.
Stage 2 :
Minimum changes are done since there will be another commit for kcm_touchpadx cleaning. The kcm_touchpad is changed as kcm_touchpadx and it is moved to new folder "touchpadx". Since "touchpad" folder is changed, you can review the diff by checking it. Tested on X and everything is working fine. In Wayland, the KCM is not shown at all.
If we go with this split the stages should be:
Stage 3
kcm_touchpad (Wayland) and kcm_touchpadx (X11) are available by this commit. Tested and working fine. To test it, you should manually remove the old kcm_touchpad files since the names are clashing imho. This problem will be handled by packagers after the patch is pushed to master. I'm implementing the backend now (kcm.cpp, kcm.h).
In D13997#289384, @romangg wrote:If we go with this split the stages should be:
- Append an x to the name of the old Touchpad KCM, make the KCM show only on X and add the new Wayland KCM without the X code as kcm_touchpad.
- Remove all Wayland related code from the old KCM.
- Rewrite the new Wayland KCM as KConfigModule.
- Your stage 4.
kded_touchpad is handling the Wayland touchpad so I couldn't compile the Wayland part by just seperating it. If you know the solution, I can do that too.
Commit | Tree | Parents | Author | Summary | Date |
---|---|---|---|---|---|
11bd1550e3d2 | e92daac4b35c | f87bc30086ba | Furkan Tokac | Minimum changes are done since there will be another commit for kcm_touchpadx… (Show More…) | Jul 9 2018, 9:40 AM |
f87bc30086ba | 3c50b91558fe | 88d1eb91febd | Furkan Tokac | Splitting Touchpad KCM (Show More…) | Jul 9 2018, 7:51 AM |
Status | Author | Revision | |
---|---|---|---|
Needs Review | furkantokac | ||
Needs Review | furkantokac | ||
Needs Review | furkantokac |