Removing Wayland Part of Touchpad KCM
Needs ReviewPublic

Authored by furkantokac on Jul 9 2018, 7:54 AM.

Details

Reviewers
romangg
ngraham
Group Reviewers
Plasma
Summary

This patch removes all wayland related things in the Touchpad KCM.

For more details, see T9177

Test Plan

In Wayland, there is no Touchpad KCM support since everything is removed about Wayland. In X11, there is a fully-functional Touchpad KCM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 717
Build 729: arc lint + arc unit
furkantokac created this revision.Jul 9 2018, 7:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 9 2018, 7:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
furkantokac requested review of this revision.Jul 9 2018, 7:54 AM
furkantokac edited the summary of this revision. (Show Details)Jul 9 2018, 7:55 AM
furkantokac edited the test plan for this revision. (Show Details)
furkantokac added reviewers: romangg, ngraham.

Since you can review the old diff, I'm moving to stage 2. If you have problem with the Stage 1's diff, please tell me.

furkantokac edited the summary of this revision. (Show Details)Jul 9 2018, 8:37 AM
furkantokac edited the summary of this revision. (Show Details)Jul 9 2018, 8:42 AM
furkantokac edited the summary of this revision. (Show Details)Jul 9 2018, 8:48 AM
furkantokac edited the summary of this revision. (Show Details)Jul 9 2018, 8:55 AM
furkantokac updated this revision to Diff 37438.Jul 9 2018, 9:45 AM

Stage 2 :
Minimum changes are done since there will be another commit for kcm_touchpadx cleaning. The kcm_touchpad is changed as kcm_touchpadx and it is moved to new folder "touchpadx". Since "touchpad" folder is changed, you can review the diff by checking it. Tested on X and everything is working fine. In Wayland, the KCM is not shown at all.

furkantokac edited the test plan for this revision. (Show Details)Jul 9 2018, 9:48 AM

If we go with this split the stages should be:

  1. Append an x to the name of the old Touchpad KCM, make the KCM show only on X and add the new Wayland KCM without the X code as kcm_touchpad.
  2. Remove all Wayland related code from the old KCM.
  3. Rewrite the new Wayland KCM as KConfigModule.
  4. Your stage 4.
furkantokac updated this revision to Diff 37464.Jul 9 2018, 3:54 PM
furkantokac edited the test plan for this revision. (Show Details)

Stage 3
kcm_touchpad (Wayland) and kcm_touchpadx (X11) are available by this commit. Tested and working fine. To test it, you should manually remove the old kcm_touchpad files since the names are clashing imho. This problem will be handled by packagers after the patch is pushed to master. I'm implementing the backend now (kcm.cpp, kcm.h).

furkantokac added a comment.EditedJul 9 2018, 3:56 PM

If we go with this split the stages should be:

  1. Append an x to the name of the old Touchpad KCM, make the KCM show only on X and add the new Wayland KCM without the X code as kcm_touchpad.
  2. Remove all Wayland related code from the old KCM.
  3. Rewrite the new Wayland KCM as KConfigModule.
  4. Your stage 4.

kded_touchpad is handling the Wayland touchpad so I couldn't compile the Wayland part by just seperating it. If you know the solution, I can do that too.

furkantokac edited the test plan for this revision. (Show Details)Jul 9 2018, 3:59 PM
furkantokac retitled this revision from Splitting Touchpad KCM to Removing Wayland Part of Touchpad KCM.
furkantokac edited the summary of this revision. (Show Details)
furkantokac edited the test plan for this revision. (Show Details)