This review is for updated screenshots for the manual. I just added myself and the team as reviewers. The image quality looks good overall. Just a few specific comments:

• account_edit.png looks like it is from the new account wizard, not the edit account dialog. Was it just saved under the wrong name?
• the kmy file used (in title bar of all full window shots) is screenshots.kmy. While this is not explicitly wrong, it might make more sense to stick with something like MySampleFinances.kmy. (I could send you the one previusly used, or you could create a new one with similar finances but more current dates.)
• I don't know whether translations also use localized screenshots, but if not, it might be better to use a date format with month name (long or short) to avoid any possible confusion between mm/dd and dd/mm. (this may not matter, I just raise the question.)
• new.png - I'm not sure where it is used, but the new version looks like an icon for a missing icon, not for adding anything. please confirm.

Question for the developers:

• categoryedit.png - the old create new category dialog had a title of "Create and new Category" but it is now "New Account Dialog - KMyMoney." Was this an intentional switch? I know categories are a type of account, but this could be confusing to new users.
• same question with the csv importer wizard. Old title "CSV Importer" new title KMyMoney.

My responses to the comments:

• The dialog I get when I choose "Edit Account" from the context menu has the title "New Account Dialog" even though the account was existing.
• I would appreciate the file you used previously, but I could also save the file with a different name and retake ones with the "screenshots.kmy" in the title bar.
• I just quickly scanned the KMM settings and KDE settings, it wasn't immediately apparent how to change the date to a more clear format. If you would like a more clear date format, I'll dig into that more and retake the necessary screen shots.
• new.png is used for the "New Document" icon. See for example categories.png the left most icon in the toolbar underneath the "File" menu bar item.

I appreciate the feedback!

Joshua

In D13994#293385, @ostroffjh wrote:

This review is for updated screenshots for the manual. I just added myself and the team as reviewers. The image quality looks good overall. Just a few specific comments:

• account_edit.png looks like it is from the new account wizard, not the edit account dialog. Was it just saved under the wrong name?

[...]

Question for the developers:

• categoryedit.png - the old create new category dialog had a title of "Create and new Category" but it is now "New Account Dialog - KMyMoney." Was this an intentional switch? I know categories are a type of account, but this could be confusing to new users.

These two are fixed in masterwith 2be9278ce788f59b044e43f3b04efc9e72fe5baa.

@tbaumgart Can you also check the account edit dialog. I just checked, and it is titled new account dialog.

In D13994#293756, @ostroffjh wrote:

@tbaumgart Can you also check the account edit dialog. I just checked, and it is titled new account dialog.

@ostroffjh Not with the above mentioned commit in place. Did you get tricked by your build environment? Otherwise, I am interested in how you exactly open the dialog, because for me it show 'Edit account dialog - KMyMoney'.

My bad. I misread (or read too fast) your comment (or how much of my message you quoted.) I do need to recompile and try again. Should be OK.

When I run 'arc land' I get the error

Landing current branch 'arcpatch-D13994'.
 TARGET  Landing onto "master", the default target under git.
 REMOTE  Using remote "origin", the default remote under git.
 FETCH  Fetching origin/master...
This commit will be landed:

      - 1c0048ca Updated screen shots in user documentation for KMyMoney 5.0.1

Landing revision 'D13994: Updated screen shots in user documentation for KMyMoney 5.0.1'...
 BUILDS PASSED  Harbormaster builds for the active diff completed successfully.
 PUSHING  Pushing changes to "origin/master".
fatal: remote error: service not enabled: /kmymoney.git
Usage Exception: Push failed! Fix the error and run "arc land" again.

Where origin is:

origin  git://anongit.kde.org/kmymoney.git (fetch)
origin  git://anongit.kde.org/kmymoney.git (push)

Any clue on what is going on?

In D13994#297358, @joshuac wrote:

origin  git://anongit.kde.org/kmymoney.git (fetch)
origin  git://anongit.kde.org/kmymoney.git (push)

Any clue on what is going on?

You cannot push to anongit as the name implies. For push you need ssh://git@git.kde.org/kmymoney.git as origin which also requires write access to KDE repositories. In case you don't have that, please let us know and we land it for you.

I don't have a KDE developer account. I could apply for one, but in the meantime perhaps someone else could land this patch?

I'll be glad to land this. Locally it does look like the commit has the correct author, so unless someone says otherwise, I'll land it later this evening.

I tried landing this using arc, but got "remote: Audit failure - Commit ab7fee01413bd1870dbcc562b6791721ec4d6064 - Non-full name: Joshua".

I think that commit ID is the one the landing is trying to create, but the commit in the diff itself (different commit ID) is

commit 7502c090e1b90d223e72a813195b5a4c6f3fa46b
Author: Joshua <chrisjoshtopher@gmail.com>
Date: Sun Jul 29 18:33:18 2018 -0400

I do not know if joshuac can simply add a commit (any minor change) to the diff, using a full author name and then KDE's git will accept it, or if it would be necessary to drop this diff and redo from scratch using an acceptable name in the commit. I'm also tempted to open a KDE admin ticket asking why Phabricator will accept commits that KDE git will not.

Any other thoughts on how to proceed?