Remove audio setup from Phonon KCM
AbandonedPublic
Actions

Authored by nicolasfella on Jul 7 2018, 7:47 PM.

Details

Reviewers

sitter
drosca

Group Reviewers

Plasma

Summary

Once D13931 has landed this is entirely duplicated and should be removed.

Depends on D13931

One step closer to T9091

Test Plan

Build and open KCM. Only Device Preference and Backend Tab is shown

Diff Detail

Repository

R119 Plasma Desktop

Branch

removeaudiosetup

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 664
Build 676: arc lint + arc unit

nicolasfella created this revision.Jul 7 2018, 7:47 PM

Restricted Application added a project: Plasma. · View Herald TranscriptJul 7 2018, 7:47 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

nicolasfella requested review of this revision.Jul 7 2018, 7:47 PM

Harbormaster completed remote builds in B664: Diff 37295.Jul 7 2018, 7:47 PM

drosca resigned from this revision.Jul 12 2018, 2:43 PM

nicolasfella edited the summary of this revision. (Show Details)Jul 14 2018, 1:38 PM

This is on my radar and looked good from a diff review. I'd like to give this a proper review though and that will take a bit as I am super swamped just now.

nicolasfella mentioned this in D14340: [Multimedia KCM] Kill PulseAudio device setup.Jul 24 2018, 7:51 PM

Abandoning in favor of D14340

Revision Contents
Changeset List

		Path
M		kcms/phonon/CMakeLists.txt (32 lines)
D	M	kcms/phonon/audiosetup.h (98 lines)
D	M	kcms/phonon/audiosetup.cpp (884 lines)
D	M	kcms/phonon/audiosetup.ui (224 lines)
M		kcms/phonon/main.h (12 lines)
M		kcms/phonon/main.cpp (18 lines)