Differential D1393

Refactor models
ClosedPublic
Actions

Authored by drosca on Apr 12 2016, 3:52 PM.

Tags

Subscribers

sebas, broulik, plasma-devel

Details

Reviewers

Group Reviewers

Commits

R994:9b4cb4957bbc: Refactor models
R115:9b4cb4957bbc: Refactor models

Summary

move all code to AbstractModel
make all models writable
only emit dataChanged with changed property role
remove unused models

Diff Detail

Repository

R115 Plasma Audio Volume Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

drosca updated this revision to Diff 3299.Apr 12 2016, 3:52 PM

drosca retitled this revision from to Refactor models.

drosca updated this object.

drosca edited the test plan for this revision. (Show Details)

drosca added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptApr 12 2016, 3:52 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Nice

src/maps.h
95	Not too fond of allocating a list just to get an item from it, can we perhaps do something like (m_data.constBegin() + index).value();
src/pulseaudio.h
46	You don't need slots to connect to with the new connect syntax iirc

Improve indexOfObject and objectAt

drosca marked 2 inline comments as done.Apr 12 2016, 8:19 PM

nice job

This revision is now accepted and ready to land.Apr 14 2016, 12:23 PM

Closed by commit R115:9b4cb4957bbc: Refactor models (authored by drosca). · Explain WhyApr 14 2016, 6:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/maps.h (52 lines)
M			src/pulseaudio.h (156 lines)
M			src/pulseaudio.cpp (387 lines)
M			src/qml/plugin.cpp (2 lines)

Diff 3341

src/maps.h

Loading...

src/pulseaudio.h

Loading...

src/pulseaudio.cpp

Loading...

src/qml/plugin.cpp

Loading...