[Fonts KCM] Generate font rendering previews only on X
ClosedPublic

Authored by broulik on Jul 6 2018, 9:43 AM.

Details

Summary

It uses Xft unconditionally and crashes the entire module when run on Wayland.

BUG: 396214
FIXED-IN: 5.13.3

Test Plan

Without the previews, the delegate in the combo doesn't fill entire popup width but that's a separate bug and mostly cosmetic and a lot better than the entire thing crashing :)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 6 2018, 9:43 AM
Restricted Application added a project: Plasma. ยท View Herald TranscriptJul 6 2018, 9:43 AM
Restricted Application added a subscriber: plasma-devel. ยท View Herald Transcript
broulik requested review of this revision.Jul 6 2018, 9:43 AM
alexeymin added a subscriber: alexeymin.EditedJul 6 2018, 10:08 AM

This is probably for BUG: 396214 ?

Meh, sorry, I'm blind ๐Ÿ˜ž

Yes, it says in the commit message

(@progwolff CC'ing you here in case later on you're motivated to look into Wayland support for the feature you contributed โ€“ once you're less busy with more important things ;)

This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2018, 12:01 PM
This revision was automatically updated to reflect the committed changes.