ActionStateManager: separate selected collections from favorites.
ClosedPublic

Authored by dfaure on Jul 4 2018, 9:04 PM.

Details

Summary

When filtering the folder tree (e.g. type "zzz"), a favorite can
be selected, but without any selection in the folder tree.
So the code should stop assuming that both selections are the same.

That testcase is still broken when it comes to actually reading
that favorite folder, but at least the popupmenu actions work now.

Test Plan

As described above, in kmail.

Diff Detail

Repository
R165 Akonadi
Branch
Applications/18.04
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 605
Build 617: arc lint + arc unit
dfaure created this revision.Jul 4 2018, 9:04 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 4 2018, 9:04 PM
Restricted Application edited subscribers, added: kde-pim; removed: KDE PIM. · View Herald Transcript
dfaure requested review of this revision.Jul 4 2018, 9:04 PM

Ok it seems to work here.
+1

vkrause accepted this revision.Jul 5 2018, 7:27 AM
This revision is now accepted and ready to land.Jul 5 2018, 7:27 AM
dfaure closed this revision.Jul 5 2018, 9:23 AM