Differential D13890

Add variable manager and fix some unicode errors for R backend
ClosedPublic
Actions

Authored by sirgienko on Jul 4 2018, 8:16 PM.

Details

Reviewers
asemke
Commits
R55:cddfdcc3669d: Add variable manager and fix some unicode errors for R backend
R55:7a860d6fcb2a: Add variable manager and fix some unicode errors for R backend

Diff Detail

Repository
R55 Cantor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sirgienko created this revision.Jul 4 2018, 8:16 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 4 2018, 8:16 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
sirgienko requested review of this revision.Jul 4 2018, 8:16 PM
asemke added inline comments.Jul 7 2018, 6:05 AM
src/backends/R/rextensions.cpp
95

use Q_UNUSED(fileName) here.

src/backends/R/rsession.cpp
138

use "int i" here to avoid signed vs. unsigned int comparisons

sirgienko updated this revision to Diff 37280.Jul 7 2018, 8:24 AM
sirgienko retitled this revision from Add variable manager and fix some unicode errors for R backend to Add variable manager and fix some unicode errors for R backend.

Update

sirgienko marked 2 inline comments as done.Jul 7 2018, 8:25 AM
asemke accepted this revision.Jul 7 2018, 4:24 PM
This revision is now accepted and ready to land.Jul 7 2018, 4:24 PM
Closed by commit R55:cddfdcc3669d: Add variable manager and fix some unicode errors for R backend (authored by sirgienko). · Explain WhyJul 7 2018, 6:55 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 5 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 37294

View Options

src/backends/R/rextensions.cpp

Loading...
View Options

src/backends/R/rserver/rserver.cpp

Loading...
View Options

src/backends/R/rsession.cpp

Loading...