Add variable manager and fix some unicode errors for R backend
ClosedPublic
Actions

Authored by sirgienko on Jul 4 2018, 8:16 PM.

Details

Reviewers

Commits

Repository

R55 Cantor

Branch

r-variable-manager

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 655
Build 667: arc lint + arc unit

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

sirgienko requested review of this revision.Jul 4 2018, 8:16 PM

src/backends/R/rextensions.cpp
95 ↗	(On Diff #37158)	use Q_UNUSED(fileName) here.
src/backends/R/rsession.cpp
138 ↗	(On Diff #37158)	use "int i" here to avoid signed vs. unsigned int comparisons

Update

sirgienko marked 2 inline comments as done.Jul 7 2018, 8:25 AM

This revision is now accepted and ready to land.Jul 7 2018, 4:24 PM

This revision was automatically updated to reflect the committed changes.

This revision modifies 6 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

			Path	Packages
M			src/backends/R/rextensions.cpp (43 lines)
M			src/backends/R/rsession.cpp (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	37158	b0d6444		Jul 4 2018, 8:15 PM	★	★
Diff 2	37280	b0d6444	Update	Jul 7 2018, 8:24 AM	★	★
Diff 3	37294	6a80512	R55:cddfdcc3669d0922f712831fd6738113a9277a5d	Jul 7 2018, 5:34 PM	★	★