Differential D13883

Don't keep transfer div in DOM
ClosedPublic
Actions

Authored by broulik on Jul 4 2018, 12:38 PM.

Details

Reviewers
davidedmundson
fvogt
Group Reviewers
Plasma
Commits
R856:114a1aa927b2: Don't keep transfer div in DOM
Summary

This confuses websites. Instead keep a references to it as a variable which works just as well

Test Plan

Tested media sessions API still works
Didn't find the website that supposedly broke by it

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 4 2018, 12:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 4 2018, 12:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 4 2018, 12:38 PM
davidedmundson accepted this revision.Jul 5 2018, 1:25 PM
This revision is now accepted and ready to land.Jul 5 2018, 1:25 PM
Closed by commit R856:114a1aa927b2: Don't keep transfer div in DOM (authored by broulik). · Explain WhyJul 5 2018, 1:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/content-script.js (18 lines)

Diff 37142

View Options

extension/content-script.js

Loading...