Differential D13874

textplugin: Fix missing QTextStream include
ClosedPublic
Actions

Authored by alistairf on Jul 3 2018, 8:20 PM.

Details

Reviewers
kossebau
Commits
R112:6b2036cb8a1d: textplugin: Fix missing QTextStream include
Summary

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

Diff Detail

Repository
R112 Milou
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alistairf created this revision.Jul 3 2018, 8:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 3 2018, 8:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
alistairf requested review of this revision.Jul 3 2018, 8:20 PM
kossebau added a comment.Jul 3 2018, 8:56 PM

Not the maintainer, just did some commits recently :) Thanks for the patch. Seems this is needed with some newer version of Qt? Some >5.11.1?

Can you commit yourself? Should go to Plasma/5.12 branch possibly, to make that one work as well with newer Qt.

kossebau accepted this revision.Jul 3 2018, 8:58 PM
This revision is now accepted and ready to land.Jul 3 2018, 8:58 PM
alistairf added a comment.Jul 12 2018, 8:39 PM

Hey, sorry this slipped through. I don't have push access. Who can commit this?

Closed by commit R112:6b2036cb8a1d: textplugin: Fix missing QTextStream include (authored by alistairf, committed by vkrause). · Explain WhyJul 17 2018, 6:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlib/previews/textplugin.cpp (2 lines)

Diff 37982

View Options

lib/previews/textplugin.cpp

Loading...