Correct Folder View sizing and representation switch behavior
ClosedPublic

Authored by hein on Jul 3 2018, 4:12 PM.

Details

Summary
  • Resolve inherent layout hint conflicts between full and compact representations by setting them seperately. This fixes a recent regression causing tiny popups.

BUG:395477

  • Correctly respect the panel icon size hint when scaling the compact representation, with the code and behavior now matching the Icon applet.
  • Only expand into the full representation in place on vertical panels. This is not a bugfix, and optional. But I think the expansion is useless on horizontal panels, and this means fewer users have to care about changing the panel icon size hint if they're using a really tall horizontal panel or Latte with parabolic zooming.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Jul 3 2018, 4:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 3 2018, 4:12 PM
hein requested review of this revision.Jul 3 2018, 4:12 PM
hein planned changes to this revision.Jul 3 2018, 4:19 PM

Whoops, I accidentally uploaded the wrong diff, hang on.

hein updated this revision to Diff 37114.Jul 3 2018, 4:30 PM
  • Add the missing switch stuff.
  • Remove stray debug.
hein updated this revision to Diff 37115.Jul 3 2018, 4:32 PM

Add back useful comment.

In D13870#286578, @hein wrote:

Add back useful comment.

I tested the patch and I couldnt reproduce the tiny popup window with plasma,
I checked also the Latte parabolic effect and it was working.

+1, Good work Eike!

mvourlakos accepted this revision.Jul 4 2018, 3:32 PM
This revision is now accepted and ready to land.Jul 4 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.
kossebau added inline comments.
containments/desktop/package/contents/ui/main.qml
58

This and the same below sadly results in error log output e.g. when testing applets with plasmoidviewer:

file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/main.qml:61:5: Unable to assign [undefined] to int
file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/main.qml:52:5: Unable to assign [undefined] to int

Seems to be able to assign null or undefined to a property the respective property needs to have a RESET method defined.

Unsure myself what undefined even should mean here, and whether a RESET method is better than just assigning some dummy value here.