[KdePlasma-Addons/POTD/NOAA] Fixed the web address and fetched the picture from new address

Authored by tagorechandanreddy on Jul 3 2018, 12:13 PM.



The web address for NOAA is no longer valid. So, the new address had to be provided.

Old address: http://www.nnvl.noaa.gov/imageoftheday.php
new address: https://www.nesdis.noaa.gov/content/imagery-and-data

'Image of the day' has a new landing page everyday. So the code had to slightly altered to fetch image from new address.

Test Plan

All plugins should work as usual.

Diff Detail

R114 Plasma Addons
Lint Skipped
Unit Tests Skipped
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJul 3 2018, 12:13 PM
tagorechandanreddy requested review of this revision.Jul 3 2018, 12:13 PM
tagorechandanreddy edited the test plan for this revision. (Show Details)

Made RegExp changes to simplify.

Further RegExp changes

ngraham added a subscriber: ngraham.Jul 7 2018, 8:55 PM

Nice, works for me!

kossebau resigned from this revision.Jul 10 2018, 3:27 PM

Looks like proper work from a quick reading glance at the patch, thanks for providing the patch, Again, not the maintainer and no time to properly review. Needs someone from the active Plasma team to get this in. If no-one responded in the next few days, please ping people again by making another comment here and perhaps trying to poke individual members from https://phabricator.kde.org/project/members/35/ by mentioning them in the comment.

Please also consider becoming maintainer of the potd project, at least for a while, now that you care for it a bit :)

When pushing in the end, please consider applying to 5.12 branch as well, so users of that LTS version can continue to use this potd source instead of experiencing it being dead.

davidedmundson accepted this revision.Jan 9 2019, 11:48 PM
This revision is now accepted and ready to land.Jan 9 2019, 11:48 PM

@tagorechandanreddy, can you provide us with your email address?

@ngraham My email address: tagore.chandan@gmail.com

This revision was automatically updated to reflect the committed changes.
ngraham added a comment.EditedJan 13 2019, 3:55 PM

@tagorechandanreddy Hmm, I'm not seeing that this actually works. Console spew says:

kf5.kio.core: Invalid URL: QUrl("/content/three-views-winter-solstice-space")
file:///usr/share/plasma/wallpapers/org.kde.potd/contents/ui/main.qml:46: TypeError: Cannot read property 'Image' of undefined

Is this a bug in your code, or a side effect of the U.S. government being shut down right now? The data source web page (https://www.nesdis.noaa.gov/content/imagery-and-data) says:

I can confirm that it is due to current state of U.S. government.

Given the frequency with which it seems to be happening these days, maybe we should explicitly handle this case!


I'm already working on it.

Please put the new stuff in another patch. I've already landed this one.