Differential D13864

[Splash Screen KCM] Fix "no thumbnail" icon for "None"
ClosedPublic
Actions

Authored by broulik on Jul 3 2018, 8:17 AM.

Details

Reviewers
mart
davidedmundson
Group Reviewers
Plasma
Commits
R119:50b1acf4016a: [Splash Screen KCM] Fix "no thumbnail" icon for "None"
Summary

In JavaScript undefined does not convert to empty string, so undefined != "" is always true.
The role isn't added to the QStandardItemModel for "None", so it is undefined (null QVariant) as far as QML is concerned.

Test Plan

5.13
"None" has the "no thumbnail available" icon now

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 3 2018, 8:17 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 3 2018, 8:17 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 3 2018, 8:17 AM
davidedmundson accepted this revision.Jul 3 2018, 2:40 PM
This revision is now accepted and ready to land.Jul 3 2018, 2:40 PM
Closed by commit R119:50b1acf4016a: [Splash Screen KCM] Fix "no thumbnail" icon for "None" (authored by broulik). · Explain WhyJul 3 2018, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37092

View Options

kcms/ksplash/package/contents/ui/main.qml

Loading...