KPluginInfo(KService::Ptr) is deprecated in favor of using plugin
loaders.
Details
Details
- Reviewers
apol davidedmundson - Group Reviewers
KWin - Commits
- R108:f48cf072f9da: [kcmkwin/kwindesktop] Use PackageLoader to get effect metadata
- Go to System Settins -> Desktop Behavior > Virtual Desktops
- Open Switching tab
- Select Fade desktop
- Click the info button
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
For scripted effects, yes, they're packages
For a 3rd party C++ plugin effects with a matching .desktop file and this will no longer have the right data.
Kwin in the general case supports both.
Right now showDialog is only used in the case where the list is hardcoded anyway, but that could change.
Give me a bit to work out what's right.
Comment Actions
Metadata should be built in. I.e. for 3rd party C++ effects metadata is obtained through KPluginLoader.
Virtual desktops KCM doesn't support 3rd party C++ effects. Effects that animate switching between virtual desktops are hard coded all the way down.
Kwin in the general case supports both.
Right now showDialog is only used in the case where the list is hardcoded anyway, but that could change.
It would be great. :-)
Give me a bit to work out what's right.
Sure.
Comment Actions
Meh I still don't understand why KPluginInfo(KService) is deprecated it makes no sense, given using KService for plugins is not yet deprecated.
In any case the correct future thing to do would be for us to drop KService and use KPackageLoader directly for scripted effects and KPluginLoader directly for binary effects.
This is part of that. Ship it.