Remove pointless setMin/setMax size on DesktopView
ClosedPublic

Authored by davidedmundson on Jul 2 2018, 2:57 PM.

Details

Summary

On X, this is entirely useless.There's a special code path in create for
windowType == Desktop and in ::setGeometry it doesn't seem to help/hinder.
It's not like we need WM_NORMAL_HINTS for a WM to resize us.

On wayland it's downright destructive.
On the second setGeometry call the QPA bounds the new geography to the
current min/max (from our previous screenGeometryChanged). But updating
the min/max doesn't update our geometry. End result is our screen is
off.

Test Plan

Resized screen on Wayland. Wallpaper now filled exactly instead of being broken
Resized screen on Xcb. Wallpaper still filled the screen precisely

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 560
Build 572: arc lint + arc unit
davidedmundson created this revision.Jul 2 2018, 2:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 2 2018, 2:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jul 2 2018, 2:57 PM
broulik accepted this revision.Jul 5 2018, 1:24 PM
This revision is now accepted and ready to land.Jul 5 2018, 1:24 PM
This revision was automatically updated to reflect the committed changes.