replace some else / if constructs to ternaries where it made sense.
This makes the code easier to read, removes the usage of temporaries and reduces loc count.
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Branch
- bookmarkHandlerTernaries
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 789 Build 802: arc lint + arc unit
Comment Actions
I don't mind the smaller ones, but I'm not 100% sure about some of the multi-line ones.
Also, we use the ==nullptr per "readability-implicit-bool-cast" - I think it makes the code easier to understand and avoids confusion about what you're checking (implicit casts).
Comment Actions
Also, we use the ==nullptr per "readability-implicit-bool-cast" - I think it makes the code easier to understand and avoids confusion about what you're checking (implicit casts).
I'll update on that.
Specially for the multiline ones ternaries can improve readability if we are only doing a single variable value assignmnent.