Differential D13843

[effects/slide] Expose support information
ClosedPublic
Actions

Authored by zzag on Jul 2 2018, 9:26 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:c3fd38e18286: [effects/slide] Expose support information
Summary

That's mostly to analyze what options people use in bug reports.

Test Plan
  • Enabled the Slide effect
  • Ran qdbus org.kde.KWin /KWin supportInformation

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jul 2 2018, 9:26 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 2 2018, 9:26 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 2 2018, 9:26 AM
davidedmundson accepted this revision.Jul 2 2018, 9:31 AM
davidedmundson added a subscriber: davidedmundson.

FYI,

Q_PROPERTY(int foo MEMBER m_foo) saves writing getters just for moc.

This revision is now accepted and ready to land.Jul 2 2018, 9:31 AM
zzag added a comment.Jul 2 2018, 9:40 AM
In D13843#285965, @davidedmundson wrote:

FYI,

Q_PROPERTY(int foo MEMBER m_foo) saves writing getters just for moc.

IIRC, MEMBER also makes the property writable. In this case, it would be better to have read only properties. (or is there a way to make MEMBER read only?)

Closed by commit R108:c3fd38e18286: [effects/slide] Expose support information (authored by zzag). · Explain WhyJul 2 2018, 5:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/slide/slide.h (37 lines)

Diff 37075

View Options

effects/slide/slide.h

Loading...