Differential D13839

[effects/cube] Change type of the rotationDuration property to int
ClosedPublic
Actions

Authored by zzag on Jul 2 2018, 8:36 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:a1e76b4802ce: [effects/cube] Change type of the rotationDuration property to int
Summary

Currently, type of the rotationDuration is std::chrono::milliseconds.
std::chrono::milliseconds is an unregistered datatype so we can't really
use it with Q_PROPERTY.

Test Plan

Ran qdbus org.kde.KWin /KWin supportInformation.

Diff Detail

Repository
R108 KWin
Branch
effects-cube-milliseconds-to-int
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 548
Build 560: arc lint + arc unit
zzag created this revision.Jul 2 2018, 8:36 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 2 2018, 8:36 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jul 2 2018, 8:36 AM
davidedmundson accepted this revision.Jul 2 2018, 8:37 AM
This revision is now accepted and ready to land.Jul 2 2018, 8:37 AM
Closed by commit R108:a1e76b4802ce: [effects/cube] Change type of the rotationDuration property to int (authored by zzag). · Explain WhyJul 2 2018, 9:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/cube/cube.h (6 lines)

Diff 37031

View Options

effects/cube/cube.h

Loading...