Differential D13776

Move remaining salt file operations into unprivileged processes
ClosedPublic
Actions

Authored by fvogt on Jun 28 2018, 7:52 AM.

Details

Reviewers
aacid
Group Reviewers
Plasma
Commits
R107:c78e8ade9e2b: Move remaining salt file operations into unprivileged processes
Summary

Otherwise the salt is always recreated on with ~ on NFS with root_squash
as root does not have access.

Test Plan

Reporter confirmed that it works and fixes the issue for him.

Diff Detail

Repository
R107 KWallet PAM Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Jun 28 2018, 7:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 28 2018, 7:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
fvogt requested review of this revision.Jun 28 2018, 7:52 AM
fvogt updated this revision to Diff 36826.Jun 28 2018, 11:24 AM

Rebase on master - this only makes sense with the user privileges salt file reading.

fvogt retitled this revision from Move the salt file existence check into the unprivileged process to Move remaining salt file operations into unprivileged processes.Jun 28 2018, 11:25 AM
fvogt edited the summary of this revision. (Show Details)
fvogt updated this revision to Diff 36827.Jun 28 2018, 11:26 AM

Fix rebase error

fvogt edited the test plan for this revision. (Show Details)Jun 28 2018, 12:02 PM
aacid added a comment.Jul 2 2018, 8:57 PM

Are you saying that there are files that root can't read but the user can?

fvogt added a comment.Jul 9 2018, 3:04 PM

Are you saying that there are files that root can't read but the user can?

Exactly.

aacid added a comment.Jul 9 2018, 10:16 PM
In D13776#289490, @fvogt wrote:

Are you saying that there are files that root can't read but the user can?

Exactly.

This is really interesting and shows how little i know about stuff, can you point me to some info about when/how this happens?

fvogt added a comment.Jul 10 2018, 6:44 AM
In D13776#289669, @aacid wrote:
In D13776#289490, @fvogt wrote:

Are you saying that there are files that root can't read but the user can?

Exactly.

This is really interesting and shows how little i know about stuff, can you point me to some info about when/how this happens?

Search for nfs root squashing.

aacid added a comment.Jul 10 2018, 9:45 PM

Ok, looks good on paper, i have not had time to test this and i don't think i'll have until at least next week since i'm going away on holiday in 24h.

If you are confident you have tried this and doesn't break the regular use cases (i.e. file is already there and file isn't already there with a "normal" filesystem layout) you can commit it.

If you prefer for me to test it, please say so and i'll do test it next week.

aacid accepted this revision.Jul 26 2018, 10:40 PM
This revision is now accepted and ready to land.Jul 26 2018, 10:40 PM
Closed by commit R107:c78e8ade9e2b: Move remaining salt file operations into unprivileged processes (authored by fvogt). · Explain WhyJul 27 2018, 6:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mpam_kwallet.c (26 lines)

Diff 38556

View Options

pam_kwallet.c

Loading...