[KDirOperator] Use alternating background colors for multi-column views
ClosedPublic

Authored by ngraham on Jun 27 2018, 11:39 PM.

Details

Summary

This makes KDirOperator's multi-column list views match those of Dolphin, which currently uses this alternating style for them.

We don't change the single-column Tree View because an alternating background doesn't improve anything there. The whole purpose, after all, is to make it easier to see the corresponding data in another column.

Test Plan

Alternating row background colors for multi-column list views (Detailed View and Detailed Tree View)

Standard background color for the single-column Tree View.

Diff Detail

Repository
R241 KIO
Branch
alternating-row-colors-for-list-style-views (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 401
Build 401: arc lint + arc unit
ngraham created this revision.Jun 27 2018, 11:39 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 27 2018, 11:39 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 27 2018, 11:39 PM
ngraham edited the test plan for this revision. (Show Details)Jun 27 2018, 11:40 PM
ngraham edited the summary of this revision. (Show Details)Jun 28 2018, 1:59 PM
ngraham updated this revision to Diff 37920.Jul 17 2018, 3:24 AM

Only use the alternating row colors for multi-column views, to avoid having it on any vertical sidebar-style lists

ngraham retitled this revision from [KDirOperator] Use alternating background colors for list-style views to [KDirOperator] Use alternating background colors for multi-column views.Jul 17 2018, 3:28 AM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
abetts accepted this revision.Jul 25 2018, 3:43 AM

Looks good!

This revision is now accepted and ready to land.Jul 25 2018, 3:43 AM
ngraham closed this revision.Jul 25 2018, 4:33 AM