Add AppStream metadata
ClosedPublic

Authored by ngraham on Jun 27 2018, 11:16 PM.

Details

Reviewers
apol
mak
Group Reviewers
Plasma
Commits
R106:daa9e0c1eb12: Add AppStream metadata
Summary

Add AppStream Metadata for KSysGuard, since it's currently lacking.

Test Plan

Compile and install; the AppStream file is installed to /usr/share/metainfo/.

Diff Detail

Repository
R106 KSysguard
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jun 27 2018, 11:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 27 2018, 11:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 27 2018, 11:16 PM

Also, I'd appreciate it if someone could please check my choice of licenses; I'm not 100% sure that I chose the right ones.

mak requested changes to this revision.Jun 28 2018, 1:23 AM
mak added a subscriber: mak.
mak added inline comments.
gui/org.kde.ksysguard.appdata.xml
3

Nitpick: Use desktop-application

8

Maybe using FSFAP as license is better here, so the sources don't have to ship a copy of the CC0 license.

19

Thumbnails are generally thrown away be the metadata extractor on the Linux distro side, so you can really drop the "type" property of the image tag here and just add the source image.

29

The component is missing a launchable tag: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable
The categories and mimetypes lists can be dropped, as those will be automatically extracted from the desktop-file mentioned in the launchable tag (if they are not dropped, the metainfo file will *override* the desktop file contents, which is likely not the desired behavior here)

This revision now requires changes to proceed.Jun 28 2018, 1:23 AM
pino requested changes to this revision.Jun 28 2018, 4:55 AM
pino added a subscriber: pino.
pino added inline comments.
gui/org.kde.ksysguard.appdata.xml
12

This is an implementation detail of (some) distributions, it makes no sense upstream, since it is all in this repository.

apol added inline comments.Jun 28 2018, 10:25 AM
gui/org.kde.ksysguard.appdata.xml
16

<url type="donation">https://www.kde.org/donate.php?app=org.kde.ksysguard</url>

ngraham updated this revision to Diff 36839.Jun 28 2018, 1:47 PM
ngraham marked 6 inline comments as done.

Address review comments

FWIW, @mak, appstrealcli validate doesn't like my launchable tag, though I can't see anything wrong with it.

dev@dev-pc:~/repos/ksysguard$  (appstream-metadata) appstreamcli validate gui/org.kde.ksysguard.appdata.xml
W - org.kde.ksysguard.appdata.xml:org.kde.ksysguard:7
    Found invalid tag: 'launchable'. Non-standard tags must be prefixed with "x-".

Validation failed: warnings: 1
mak added a comment.Jun 28 2018, 11:08 PM

FWIW, @mak, appstrealcli validate doesn't like my launchable tag, though I can't see anything wrong with it.

dev@dev-pc:~/repos/ksysguard$  (appstream-metadata) appstreamcli validate gui/org.kde.ksysguard.appdata.xml
W - org.kde.ksysguard.appdata.xml:org.kde.ksysguard:7
    Found invalid tag: 'launchable'. Non-standard tags must be prefixed with "x-".

Validation failed: warnings: 1

You have an old version of AppStream, as it looks like - ideally always update it to the most recent version (0.12.1 currently).

Are folks satisfied with this now?

apol accepted this revision.Jun 30 2018, 3:26 PM
mak accepted this revision.Jun 30 2018, 3:31 PM
pino resigned from this revision.Jun 30 2018, 4:24 PM
This revision is now accepted and ready to land.Jun 30 2018, 4:24 PM
pino removed a subscriber: pino.Jun 30 2018, 4:24 PM
pino removed a reviewer: pino.Jun 30 2018, 4:32 PM
This revision was automatically updated to reflect the committed changes.