Add AppStream Metadata for KSysGuard, since it's currently lacking.
Details
- Reviewers
apol mak - Group Reviewers
Plasma - Commits
- R106:daa9e0c1eb12: Add AppStream metadata
Compile and install; the AppStream file is installed to /usr/share/metainfo/.
Diff Detail
- Repository
- R106 KSysguard
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Also, I'd appreciate it if someone could please check my choice of licenses; I'm not 100% sure that I chose the right ones.
gui/org.kde.ksysguard.appdata.xml | ||
---|---|---|
3 | Nitpick: Use desktop-application | |
8 | Maybe using FSFAP as license is better here, so the sources don't have to ship a copy of the CC0 license. | |
19 | Thumbnails are generally thrown away be the metadata extractor on the Linux distro side, so you can really drop the "type" property of the image tag here and just add the source image. | |
29 | The component is missing a launchable tag: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable |
gui/org.kde.ksysguard.appdata.xml | ||
---|---|---|
12 | This is an implementation detail of (some) distributions, it makes no sense upstream, since it is all in this repository. |
gui/org.kde.ksysguard.appdata.xml | ||
---|---|---|
16 | <url type="donation">https://www.kde.org/donate.php?app=org.kde.ksysguard</url> |
FWIW, @mak, appstrealcli validate doesn't like my launchable tag, though I can't see anything wrong with it.
dev@dev-pc:~/repos/ksysguard$ (appstream-metadata) appstreamcli validate gui/org.kde.ksysguard.appdata.xml W - org.kde.ksysguard.appdata.xml:org.kde.ksysguard:7 Found invalid tag: 'launchable'. Non-standard tags must be prefixed with "x-". Validation failed: warnings: 1
You have an old version of AppStream, as it looks like - ideally always update it to the most recent version (0.12.1 currently).