Differential D13762

[effects/magiclamp] Port to TimeLine
ClosedPublic
Actions

Authored by zzag on Jun 27 2018, 2:56 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:138b185889cd: [effects/magiclamp] Port to TimeLine
Summary

Depends on D13740

Test Plan

Minimized/Unminimized System Setting window, still works.

Diff Detail

Repository
R108 KWin
Branch
effects-magiclamp-port-to-timeline
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 379
Build 379: arc lint + arc unit
zzag created this revision.Jun 27 2018, 2:56 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 27 2018, 2:56 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jun 27 2018, 2:56 PM
davidedmundson accepted this revision.Jun 27 2018, 3:18 PM
This revision is now accepted and ready to land.Jun 27 2018, 3:18 PM
zzag updated this revision to Diff 36852.Jun 28 2018, 7:06 PM

Delete redundant !m_animations.isEmpty() check in postPaintScreen.

davidedmundson added a comment.Jun 28 2018, 7:45 PM
This comment was removed by davidedmundson.
davidedmundson accepted this revision.Jun 28 2018, 7:55 PM

Edit, I was talking nonsense.

Closed by commit R108:138b185889cd: [effects/magiclamp] Port to TimeLine (authored by zzag). · Explain WhyJun 30 2018, 7:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36771

View Options

effects/magiclamp/magiclamp.h

Loading...
View Options

effects/magiclamp/magiclamp.cpp

Loading...