[effects/minimizeanimation] Port to TimeLine
ClosedPublic

Authored by zzag on Jun 27 2018, 2:56 PM.

Details

Summary

Depends on D13740

Test Plan

Minimized/Unminimized System Setting window, still works.

Diff Detail

Repository
R108 KWin
Branch
effects-minimizeanimation-port-to-timeline
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 378
Build 378: arc lint + arc unit
zzag created this revision.Jun 27 2018, 2:56 PM
Restricted Application added a project: KWin. · View Herald TranscriptJun 27 2018, 2:56 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jun 27 2018, 2:56 PM
davidedmundson accepted this revision.Jun 27 2018, 3:09 PM
This revision is now accepted and ready to land.Jun 27 2018, 3:09 PM
zzag updated this revision to Diff 36851.Jun 28 2018, 7:03 PM

Drop

if (!m_animations.isEmpty()) {
    effects->addRepaintFull();
}

in favor of

effects->addRepaintFull();

!m_animations.isEmpty() is redundant because when postPaintScreen is
called, we know that at least one animation is active. If there is only
one animation and it is about to be removed in the while loop, we still
would like to repaint(to "clean" up after the animation). So, in either case,
we would like to schedule repainting.

Yet, scheduling full repaint is not the greatest thing, but that was before.

This revision was automatically updated to reflect the committed changes.