[Media Frame] Fix history length property
ClosedPublic

Authored by broulik on Jun 27 2018, 1:58 PM.

Details

Summary

An invokable cannot be notified.

CCMAIL: dev.larpon@gmail.com

Test Plan

Back button is enabled and disabled correctly again

Diff Detail

Repository
R114 Plasma Addons
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jun 27 2018, 1:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 27 2018, 1:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jun 27 2018, 1:58 PM
dfaure accepted this revision.Jun 27 2018, 2:01 PM

Makes sense, binding needs to be updated when the value changes.

Thanks for the fix!

This revision is now accepted and ready to land.Jun 27 2018, 2:01 PM
davidedmundson accepted this revision.Jun 27 2018, 2:03 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
applets/mediaframe/plugin/mediaframe.cpp
336

This could have just been an else of the branch above

This revision was automatically updated to reflect the committed changes.
dfaure added inline comments.Jun 27 2018, 2:12 PM
applets/mediaframe/plugin/mediaframe.cpp
336

And then one day someone adds a check for contains() before prepend(), for instance, and you would need to come back to this structure of the code. So this is more flexible.