Solid's UDisks backend never emits the Solid::OpticalDrive::ejectPressed signal.
It is only present in HAL whereas Linux uses UDev these days.
Details
Details
- Reviewers
adridg davidedmundson dfaure fvogt ervin - Group Reviewers
Plasma Frameworks - Commits
- R120:edd5e889f583: Build solidautoeject only on FreeBSD
Thanks to @adridg for FreeBSD testing. Turned out this is still needed there.
The "proper" approach would have been to check for HAVE_UDEV or something like that but HAL on Linux has been obsolete for ages.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Since the ticket is rather unclear on what functionality is being tested, or how:
- Put a CD with an ISO9660 filesystem in the drive (I used one with Debian from 1995 on it)
- When device notifier pops up, pick "open with filemanager" (*)
- Ensure the silesystem isn't actually busy (e.g. no shells cd'd into that filesystem)
- Press the physical eject button on the drive
On FreeBSD, the filesystem is unmounted and the CD is ejected. (And the directory in /media where the drive was mounted is removed **).
Notes:
- * I get a "Error -- ... Client" popup with "Malformed URL" message, and an OK button. No idea what is causing that or where it's from -- but I don't get a file manager either.
- ** This only works if the filesystem is mounted through the device notifier. Mounting it by hand (somewhere else) neither unmounts, nor ejects, nor removes the mount point (the last bit is good, since you must have made that mount point by hand, too)
Comment Actions
It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change; what I've written above is current behavior on FreeBSD 11 with Plasma 5.12.5; HAL is running.
Comment Actions
It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change
I think you could test it by disabling the "Drive Ejector" module in "Background Services" (kded settings) in System Settings. If pressing the button still ejects the CD as before, then this patch should be good on BSD / with HAL also.
Comment Actions
I have looking on https://bugs.kde.org/show_bug.cgi?id=394348 that's using same interface when ISO is umounting?
Comment Actions
- Start systemsettings; under *workspace*, *startup and shutdown*, find *background services*.
- Untick the box for *Drive Ejector*; also check status is *not running*, click *stop* button if it is still running.
- Insert CD, pick *open in file manager* from the device notifier popup
- Check that it's mounted, from a konsole
- Press button on CD drive: no result
- Choose eject from device notifier: CD is ejected