Port from KComboBox to QComboBox
ClosedPublic

Authored by ngraham on Jun 26 2018, 10:57 PM.

Details

Summary

None of Dolphin's current usages of KComboBox use any of its additional features beyond QComboBox, so let's use QComboBox instead.

Test Plan

Tested all features that use comboboxes in Dolphin. No visual or functional changes or regressions.

Diff Detail

Repository
R318 Dolphin
Branch
port-to-qcombobox (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 375
Build 375: arc lint + arc unit
ngraham created this revision.Jun 26 2018, 10:57 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptJun 26 2018, 10:57 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
ngraham requested review of this revision.Jun 26 2018, 10:57 PM
broulik added inline comments.
src/settings/viewmodes/dolphinfontrequester.h
23

Not needed since you forward-declare it below and only use a pointer to it

src/settings/viewmodes/viewsettingstab.h
25

Not needed

src/settings/viewpropertiesdialog.h
26

Not needed

ngraham updated this revision to Diff 36763.Jun 27 2018, 1:08 PM
ngraham marked 3 inline comments as done.

Remove unnecessary #includes since we forward-declare QComboBox

Thanks, done.

This revision is now accepted and ready to land.Jun 27 2018, 8:45 PM

No problem. :)

ngraham closed this revision.Jun 27 2018, 8:47 PM