Differential D13734

Make GConf optional dependency
ClosedPublic
Actions

Authored by drosca on Jun 26 2018, 8:58 AM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

R115:c9fae1fb3f8e: Make GConf optional dependency

Summary

When building without GConf, Advanded Output Configuration will be hidden in KCM.

BUG: 386665
FIXED-IN: 5.13.2

Test Plan

Built with & without GConf

Diff Detail

Repository

R115 Plasma Audio Volume Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

drosca requested review of this revision.Jun 26 2018, 8:58 AM

drosca created this revision.

Harbormaster completed remote builds in B320: Diff 36669.Jun 26 2018, 8:58 AM

matthiasdahl added a subscriber: matthiasdahl.Jun 27 2018, 8:27 AM

Ping

What's the advantage?

In D13734#291184, @apol wrote:

What's the advantage?

Keeping plasma-pa packaged in distributions :D

You can see in the bug report, gconf is being removed from reposditories of all distributions and they are also removing plasma-pa because it no longer builds.

davidedmundson accepted this revision.Jul 12 2018, 5:14 PM

This revision is now accepted and ready to land.Jul 12 2018, 5:14 PM

asturmlechner added a subscriber: asturmlechner.Jul 12 2018, 8:43 PM

Closed by commit R115:c9fae1fb3f8e: Make GConf optional dependency (authored by drosca). · Explain WhyJul 13 2018, 11:34 AM

This revision was automatically updated to reflect the committed changes.

Restricted Application added a project: Plasma. · View Herald TranscriptJul 13 2018, 11:34 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Somehow, in some way, the changes to src/CMakeLists.txt are in 5.13 branch, but are missing in master branch.

So 5.13 builds ok without gconf, but current master fails to build.

Sorry, bad merge. Should be ok now.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (9 lines)
A	M	config.h.cmake (3 lines)
M		src/CMakeLists.txt (18 lines)
M		src/kcm/package/contents/ui/Advanced.qml (5 lines)
M		src/modulemanager.h (3 lines)
M		src/modulemanager.cpp (47 lines)