Differential D13715

Avoid potential assert in SM saving
ClosedPublic
Actions

Authored by davidedmundson on Jun 25 2018, 10:43 AM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:835455939f49: Avoid potential assert in SM saving
R108:2693e288c57a: Avoid potential assert in SM saving
Summary

Sesison Manager stores all relevant clients. There's an assert if the
window type is outside of the standard client window types. It assumed
that all windows outside this would be Unmanaged windows rather than
Client objects, something probably true but not something enforced.

This particular crash was probably cased as we have a new window type in
Plasma OSD, which does not set BypassWindowManager in Qt window flags.

BUG: 395712

Test Plan

Set to restore session
Logged out and back in
Saw some windows

Set to restore manually saved session
Hit save
No crash

Diff Detail

Repository
R108 KWin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 293
Build 293: arc lint + arc unit
Restricted Application added a project: KWin. · View Herald TranscriptJun 25 2018, 10:43 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Jun 25 2018, 10:43 AM
graesslin accepted this revision.Jun 25 2018, 3:33 PM
This revision is now accepted and ready to land.Jun 25 2018, 3:33 PM
Closed by commit R108:2693e288c57a: Avoid potential assert in SM saving (authored by davidedmundson). · Explain WhyJun 27 2018, 12:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msm.cpp (8 lines)

Diff 36633

View Options

sm.cpp

Loading...