Use QPageSize::name() for names of page sizes

Authored by pino on Jun 25 2018, 5:10 AM.



Drop the translations from KReportPageSizeInfo & pageSizeInfo, and use
what QPageSize::name() already provides.

Test Plan

Builds fine, shows the names from QPageSize as intended.

Diff Detail

R14 KReport
pagesizes (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 290
Build 290: arc lint + arc unit
pino created this revision.Jun 25 2018, 5:10 AM
Restricted Application added a project: KReport. · View Herald TranscriptJun 25 2018, 5:10 AM
pino requested review of this revision.Jun 25 2018, 5:10 AM

Thanks a lot @pino. Looks nice, in some regards even more in line with LibreOffice (US Letter -> Letter).



staniek accepted this revision.Jun 25 2018, 8:46 AM
This revision is now accepted and ready to land.Jun 25 2018, 8:46 AM
This revision was automatically updated to reflect the committed changes.

(landed to master (3.2) as translations are affected)

You can apply it also to a stable branch, because, if I'm not mistaken, the change only removes translations. Removing translated strings is not a problem.

pino added a comment.Jun 25 2018, 6:45 PM

Thanks for the approval -- note that I can already push patches on my own ;-)

Also, as @ltoscano mentioned already, this patch only removes translations (yay!), so it will not break string freezes in stable branches. Of course, it is up to you, my main goal is done :-)

note that I can already push patches on my own

Sure, I know, I just wanted to save the effort by making sure unstable is only targetted.