Drop the translations from KReportPageSizeInfo & pageSizeInfo, and use
what QPageSize::name() already provides.
Details
Details
Builds fine, shows the names from QPageSize as intended.
Diff Detail
Diff Detail
- Repository
- R14 KReport
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks a lot @pino. Looks nice, in some regards even more in line with LibreOffice (US Letter -> Letter).
Before:
After:
Comment Actions
You can apply it also to a stable branch, because, if I'm not mistaken, the change only removes translations. Removing translated strings is not a problem.
Comment Actions
Thanks for the approval -- note that I can already push patches on my own ;-)
Also, as @ltoscano mentioned already, this patch only removes translations (yay!), so it will not break string freezes in stable branches. Of course, it is up to you, my main goal is done :-)
Comment Actions
note that I can already push patches on my own
Sure, I know, I just wanted to save the effort by making sure unstable is only targetted.