| graesslin |
| KWin |
When windowClosed signal is emitted, effects can't distinguish managed
windows from unmanaged windows(e.g. combo box popups, popup menus, etc).
This leads to dirty hacks like IsXXXWindow. Also, there's a big chance
that such hack can introduce more bugs and overall this makes harder to
write/maintain effects.
This change proposes to save value of managed property during
construction of EffectWindow. So, its value is preserved with Deleted.
Manually.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Except for the virtual I like the change
| libkwineffects/kwineffects.h | ||
|---|---|---|
| 2147 | I don't see a reason to make this virtual. | |
| libkwineffects/kwineffects.h | ||
|---|---|---|
| 2147 | So, I just need to save "managed" property in EffectWindow constructor (and also add PIMPL)? No changes in EffectWindowImpl, right? | |
| libkwineffects/kwineffects.h | ||
|---|---|---|
| 2147 | Yes | |