Differential D13686

Updated RunCommand.qml to scroll with Ctrl + home row (j, k)
ClosedPublic
Actions

Authored by michaeleden on Jun 23 2018, 2:54 AM.

Details

Reviewers
broulik
davidedmundson
Group Reviewers
Plasma: Workspaces
Commits
R120:a58e48707601: Updated RunCommand.qml to scroll with Ctrl + home row (j, k)
Summary

This change allows users to scroll through krunner output using their homerow.

  • Ctrl+j: Scroll Down
  • Ctrl+k: Scroll Up

This makes scrolling easier for those familiar with this convention but doesn't inhibit users who aren't.

Diff Detail

Repository
R120 Plasma Workspace
Branch
feature/krunner-scroll-jk
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 258
Build 258: arc lint + arc unit
michaeleden created this revision.Jun 23 2018, 2:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 23 2018, 2:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
michaeleden requested review of this revision.Jun 23 2018, 2:54 AM
michaeleden edited the summary of this revision. (Show Details)Jun 23 2018, 2:55 AM
michaeleden added a subscriber: Plasma: Workspaces.
broulik added a comment.Jun 23 2018, 9:56 AM

Idea is fine I guess

lookandfeel/contents/runcommand/RunCommand.qml
190–195

I don't think QtQML supports ECMScript 6 const

michaeleden updated this revision to Diff 36570.Jun 23 2018, 4:12 PM

Use ES5 var instead of ES6 const

davidedmundson accepted this revision.Jun 25 2018, 9:42 AM
davidedmundson added a subscriber: davidedmundson.

I don't think QtQML supports ECMScript 6 const

It does.

This revision is now accepted and ready to land.Jun 25 2018, 9:42 AM
Closed by commit R120:a58e48707601: Updated RunCommand.qml to scroll with Ctrl + home row (j, k) (authored by michaeleden). · Explain WhyJul 9 2018, 2:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36570

View Options

lookandfeel/contents/runcommand/RunCommand.qml

Loading...