Differential D13672

Mouse KCM Pointer Speed Slider Improvement
ClosedPublic
Actions

Authored by furkantokac on Jun 22 2018, 7:40 AM.

Details

Reviewers
ngraham
romangg
mart
Group Reviewers
Plasma
Commits
R119:13b35bd8025a: Mouse KCM Pointer Speed Slider Improvement
Summary

Slider value to libinput value mapping algorithm is changed. Tested and everything is working fine.
You can test it by changing value on slider and checking the libinput value from ~/.config/kcminputrc

BUG: 395681

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 220
Build 220: arc lint + arc unit
furkantokac created this revision.Jun 22 2018, 7:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2018, 7:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
furkantokac requested review of this revision.Jun 22 2018, 7:40 AM
furkantokac edited the summary of this revision. (Show Details)Jun 22 2018, 7:51 AM
furkantokac added reviewers: ngraham, romangg, Plasma.
furkantokac edited the summary of this revision. (Show Details)
furkantokac edited the summary of this revision. (Show Details)
furkantokac edited the summary of this revision. (Show Details)Jun 22 2018, 7:54 AM
mart accepted this revision.Jun 22 2018, 8:45 AM
This revision is now accepted and ready to land.Jun 22 2018, 8:45 AM
ngraham accepted this revision.Jun 22 2018, 1:22 PM

BUG: 395681 can't be a link, I don't think. It's gotta just be plain old dumb text. :) Also, it seems that this is dependent on D13573. So please also add Depends on D13573 to the Summary section somewhere. Then do arc amend locally. Thanks!

And don't push until the dependent revision is landed, obviously.

furkantokac added a comment.Jun 25 2018, 6:35 PM
In D13672#281774, @ngraham wrote:

BUG: 395681 can't be a link, I don't think. It's gotta just be plain old dumb text. :)

This patch actually solves the problem specified on bug title, "libinput pointer kcm needs 11 ticks on the speed slider so that the middle one can correspond to 0.0". Still you think that it doesn't solve the bug ?

Also, it seems that this is dependent on D13573. So please also add Depends on D13573 to the Summary section somewhere. Then do arc amend locally. Thanks!

D13573 patch is for Touchpad KCM but this patch is for Mouse KCM There is a confusion 😄 So I'm going to apply the same patch for Touchpad KCM too. Same issue, same solution.

ngraham added a comment.Jun 25 2018, 7:17 PM
In D13672#282856, @furkantokac wrote:
In D13672#281774, @ngraham wrote:

BUG: 395681 can't be a link, I don't think. It's gotta just be plain old dumb text. :)

This patch actually solves the problem specified on bug title, "libinput pointer kcm needs 11 ticks on the speed slider so that the middle one can correspond to 0.0". Still you think that it doesn't solve the bug ?

No, I wasn't telling you to remove the text "BUG: 395681". I was telling you to not make it a link.

Also, it seems that this is dependent on D13573. So please also add Depends on D13573 to the Summary section somewhere. Then do arc amend locally. Thanks!

D13573 patch is for Touchpad KCM but this patch is for Mouse KCM There is a confusion 😄 So I'm going to apply the same patch for Touchpad KCM too. Same issue, same solution.

Ah yes, my mistake. Please do so!

romangg accepted this revision.Jun 26 2018, 7:52 PM
romangg added inline comments.
kcms/mouse/kcm/libinput/main.qml
199

The 0.1 was wrong before. Should be now some value in the range, probably 1.

furkantokac edited the summary of this revision. (Show Details)Jun 26 2018, 7:54 PM
ngraham added inline comments.Jun 26 2018, 8:03 PM
kcms/mouse/kcm/libinput/main.qml
199

IMHO it should be the exact middle value (0 in terms of the libinput value, or position 6 on the slider).

Material for another patch, though.

Closed by commit R119:13b35bd8025a: Mouse KCM Pointer Speed Slider Improvement (authored by furkantokac). · Explain WhyJun 26 2018, 8:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36495

View Options

kcms/mouse/kcm/libinput/main.qml

Loading...
View Options

kcms/mouse/kcm/libinput/main_deviceless.qml

Loading...